Fixes script that perform change password on hosts by RodrigoDLopez · Pull Request #6783 · apache/cloudstack

RodrigoDLopez · 2022-09-29T17:59:24Z

Description

When adding a KVM host via ACS UI, it is necessary to provide a username and password for ACS to connect via SSH to the host. When using the updateHostPassword API, ACS updates the password in the metadata. When the update_passwd_on_host parameter is specified as true, ACS sends a command to the host that causes it to run a script to change the user's password on the host.

During some internal tests, it was observed that the script was not changing the password and returned an error. Adjustments were made to this script to make it work again.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

How Has This Been Tested?

After executing the updateHostPassword API, an attempt was made to access the host via ssh using the user and the new password as a parameter. The expected result is that the password for that user has been updated, and this was the result observed during the tests.

codecov · 2022-09-29T18:47:34Z

Codecov Report

Merging #6783 (ed3a083) into main (67024b0) will increase coverage by 0.34%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #6783      +/-   ##
============================================
+ Coverage     10.52%   10.87%   +0.34%     
- Complexity     6784     7115     +331     
============================================
  Files          2464     2485      +21     
  Lines        243988   245507    +1519     
  Branches      38185    38334     +149     
============================================
+ Hits          25690    26695    +1005     
- Misses       215065   215543     +478     
- Partials       3233     3269      +36

Impacted Files	Coverage Δ
...org/apache/cloudstack/quota/vo/QuotaBalanceVO.java	`28.20% <0.00%> (-17.95%)`	⬇️
...e/cloudstack/api/command/QuotaTariffUpdateCmd.java	`44.00% <0.00%> (-8.39%)`	⬇️
...dstack/network/contrail/model/ModelObjectBase.java	`21.15% <0.00%> (-7.70%)`	⬇️
.../schema/src/main/java/com/cloud/usage/UsageVO.java	`28.97% <0.00%> (-5.88%)`	⬇️
.../org/apache/cloudstack/quota/QuotaManagerImpl.java	`44.92% <0.00%> (-5.51%)`	⬇️
...che/cloudstack/api/command/QuotaTariffListCmd.java	`66.66% <0.00%> (-4.77%)`	⬇️
...e/cloudstack/api/response/QuotaTariffResponse.java	`69.38% <0.00%> (-1.58%)`	⬇️
...schema/src/main/java/com/cloud/user/AccountVO.java	`78.68% <0.00%> (-1.32%)`	⬇️
.../src/main/java/com/cloud/storage/VMTemplateVO.java	`37.70% <0.00%> (-1.28%)`	⬇️
...in/java/com/cloud/api/query/vo/TemplateJoinVO.java	`38.09% <0.00%> (-1.15%)`	⬇️
... and 98 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

yadvr · 2022-10-08T06:26:21Z

@blueorangutan package

blueorangutan · 2022-10-08T06:27:02Z

@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

yadvr

LGTM, needs testing

blueorangutan · 2022-10-08T08:50:34Z

Packaging result: ✖️ el7 ✖️ el8 ✖️ debian ✖️ suse15. SL-JID 4380

DaanHoogland · 2022-10-11T11:40:36Z

@blueorangutan package

DaanHoogland

clgtm

blueorangutan · 2022-10-11T11:41:03Z

@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2022-10-11T12:23:31Z

Packaging result: ✖️ el7 ✖️ el8 ✖️ debian ✖️ suse15. SL-JID 4421

blueorangutan · 2022-10-12T19:55:05Z

Packaging result: ✖️ el7 ✖️ el8 ✖️ debian ✔️ suse15. SL-JID 4433

blueorangutan · 2022-10-13T07:59:57Z

Packaging result: ✖️ el7 ✔️ el8 ✖️ debian ✖️ suse15. SL-JID 4445

blueorangutan · 2022-10-13T09:48:45Z

Packaging result: ✖️ el7 ✔️ el8 ✖️ debian ✖️ suse15. SL-JID 4451

blueorangutan · 2022-10-13T11:45:05Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 4455

DaanHoogland · 2022-10-14T08:18:53Z

@blueorangutan test matrix

blueorangutan · 2022-10-14T08:20:03Z

@DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

blueorangutan · 2022-10-14T18:52:06Z

Trillian test result (tid-5122)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36605 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6783-t5122-xenserver-71.zip
Smoke tests completed. 104 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

blueorangutan · 2022-10-14T20:03:34Z

Trillian test result (tid-5124)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40954 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6783-t5124-vmware-65u2.zip
Smoke tests completed. 104 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

blueorangutan · 2022-10-14T22:57:48Z

Trillian test result (tid-5123)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 51288 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6783-t5123-kvm-centos7.zip
Smoke tests completed. 102 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_03_deploy_and_scale_kubernetes_cluster	`Failure`	3625.43	test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster	`Failure`	325.91	test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster	`Failure`	609.77	test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster	`Failure`	3604.99	test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown	`Error`	3661.26	test_kubernetes_clusters.py
test_hostha_enable_ha_when_host_in_maintenance	`Error`	303.86	test_hostha_kvm.py

DaanHoogland · 2022-10-17T08:05:59Z

@blueorangutan test

blueorangutan · 2022-10-17T08:07:03Z

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2022-10-17T19:35:11Z

Trillian test result (tid-5144)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39971 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6783-t5144-kvm-centos7.zip
Smoke tests completed. 103 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_08_upgrade_kubernetes_ha_cluster	`Failure`	599.87	test_kubernetes_clusters.py

weizhouapache · 2022-10-17T19:57:00Z

I run this script on a ubuntu 22.04 host, the password has been changed successfully, but the exit code is 1

# /usr/share/cloudstack-common/scripts/vm/hypervisor/update_host_passwd.sh root password
New password: Retype new password: passwd: password updated successfully
# echo $?
1

still needs some changes
@RodrigoDLopez

RodrigoDLopez · 2022-10-24T15:21:04Z

I run this script on a ubuntu 22.04 host, the password has been changed successfully, but the exit code is 1
# /usr/share/cloudstack-common/scripts/vm/hypervisor/update_host_passwd.sh root password
New password: Retype new password: passwd: password updated successfully
# echo $?
1
still needs some changes @RodrigoDLopez

I ran the same test with Ubuntu versions 20.04 and 22.04. However, the result in my environment was different from what was reported.

On ubuntu 20.04:

:~# /usr/share/cloudstack-common/scripts/vm/hypervisor/update_host_passwd.sh root password
New password: Retype new password: passwd: password updated successfully
:~#

On ubuntu 22.04:

:~# /usr/share/cloudstack-common/scripts/vm/hypervisor/update_host_passwd.sh root password123
New password: Retype new password: passwd: password updated successfully
:~#

can you recheck?

weizhouapache · 2022-10-24T15:41:02Z

I run this script on a ubuntu 22.04 host, the password has been changed successfully, but the exit code is 1
# /usr/share/cloudstack-common/scripts/vm/hypervisor/update_host_passwd.sh root password
New password: Retype new password: passwd: password updated successfully
# echo $?
1
still needs some changes @RodrigoDLopez
I ran the same test with Ubuntu versions 20.04 and 22.04. However, the result in my environment was different from what was reported.

On ubuntu 20.04:
:~# /usr/share/cloudstack-common/scripts/vm/hypervisor/update_host_passwd.sh root password
New password: Retype new password: passwd: password updated successfully
:~# 
On ubuntu 22.04:
:~# /usr/share/cloudstack-common/scripts/vm/hypervisor/update_host_passwd.sh root password123
New password: Retype new password: passwd: password updated successfully
:~# 
can you recheck?

@RodrigoDLopez
have you checked the exit code of the script ?

remove unused variable

DaanHoogland · 2022-12-02T08:19:44Z

scripts/vm/hypervisor/update_host_passwd.sh

+if [[ $(echo $?) -eq 0 ]]; then
   exit 0
 else
   exit 1
-fi
+fi


I don´t mind this part, but just letting the script exit will have all but the same effect; $? will be the exit code.

DaanHoogland · 2022-12-02T08:20:05Z

@blueorangutan package

blueorangutan · 2022-12-02T08:21:03Z

@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2022-12-02T09:21:10Z

Packaging result: ✖️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 4739

blueorangutan · 2022-12-02T15:53:07Z

Packaging result: ✖️ el7 ✔️ el8 ✔️ debian ✖️ suse15. SL-JID 4751

blueorangutan · 2022-12-02T17:24:21Z

Packaging result: ✔️ el7 ✔️ el8 ✖️ debian ✔️ suse15. SL-JID 4753

blueorangutan · 2022-12-02T17:28:23Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 4755

DaanHoogland · 2022-12-06T08:36:45Z

@blueorangutan test

blueorangutan · 2022-12-06T08:37:03Z

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2022-12-06T08:42:25Z

Trillian Build Failed (tid-5397)

blueorangutan · 2022-12-06T15:54:25Z

Trillian Build Failed (tid-5406)

blueorangutan · 2022-12-07T12:09:15Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 4796

weizhouapache · 2022-12-07T17:09:36Z

@blueorangutan test

blueorangutan · 2022-12-07T17:10:04Z

@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

weizhouapache

code lgtm

better to manually test this on EL7/EL8 (and similar)/ubuntu20/ubuntu22

blueorangutan · 2022-12-08T06:09:41Z

Trillian test result (tid-5419)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45401 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6783-t5419-kvm-centos7.zip
Smoke tests completed. 104 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_08_upgrade_kubernetes_ha_cluster	`Failure`	570.05	test_kubernetes_clusters.py

DaanHoogland · 2022-12-12T11:11:59Z

good point @weizhouapache
@blueorangutan test matrix

blueorangutan · 2022-12-12T11:13:03Z

@DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

blueorangutan · 2022-12-12T22:53:57Z

Trillian test result (tid-5472)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40496 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6783-t5472-kvm-centos7.zip
Smoke tests completed. 105 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

blueorangutan · 2022-12-12T23:12:46Z

Trillian test result (tid-5471)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41805 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6783-t5471-xenserver-71.zip
Smoke tests completed. 105 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

blueorangutan · 2022-12-13T00:36:35Z

Trillian test result (tid-5473)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 46895 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6783-t5473-vmware-65u2.zip
Smoke tests completed. 104 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_08_upgrade_kubernetes_ha_cluster	`Failure`	676.30	test_kubernetes_clusters.py

DaanHoogland · 2022-12-13T10:10:37Z

doing some extra manual tests on assorted environments, @RodrigoDLopez . otherwise ready to merge

rocky8 / kvm
ubuntu22 / kvm
alma9 / vmware
ubuntu20 / xcpng82

DaanHoogland · 2022-12-16T08:14:02Z

doing some extra manual tests on assorted environments, @RodrigoDLopez . otherwise ready to merge
* [x]  rocky8 / kvm

* [x]  ubuntu22 / kvm

* [ ]  alma9 / vmware

* [x]  ubuntu20 / xcpng82

@weizhouapache @RodrigoDLopez , only the vmware version failed. I am now trying a centos7 with vmware to eliminate the alma8 factor.

DaanHoogland · 2022-12-16T16:00:25Z

ok, the failures have nothing to do with this code. I also had not understood the functionality completely. redoing some tests.

DaanHoogland · 2022-12-16T16:21:29Z

tested good on xen and kvm, not supported on vmware: merging

fixes script that perform change password on hosts

01e82bb

RodrigoDLopez changed the title ~~fixes script that perform change password on hosts~~ Fixes script that perform change password on hosts Sep 29, 2022

yadvr added this to the 4.18.0.0 milestone Oct 8, 2022

yadvr approved these changes Oct 8, 2022

View reviewed changes

DaanHoogland approved these changes Oct 11, 2022

View reviewed changes

DaanHoogland added the status:needs-testing label Oct 11, 2022

GutoVeronezi approved these changes Oct 24, 2022

View reviewed changes

fix exit code

388b06b

Update update_host_passwd.sh

ed3a083

remove unused variable

DaanHoogland reviewed Dec 2, 2022

View reviewed changes

weizhouapache approved these changes Dec 7, 2022

View reviewed changes

stephankruggg approved these changes Dec 9, 2022

View reviewed changes

DaanHoogland merged commit 96aaeac into apache:main Dec 16, 2022

RodrigoDLopez deleted the fix-updateHostPassword-API branch January 9, 2023 20:20

DaanHoogland removed the status:needs-testing label Jan 28, 2026

Conversation

RodrigoDLopez commented Sep 29, 2022

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

How Has This Been Tested?

Uh oh!

codecov bot commented Sep 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

yadvr commented Oct 8, 2022

Uh oh!

blueorangutan commented Oct 8, 2022

Uh oh!

yadvr left a comment

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Oct 8, 2022

Uh oh!

DaanHoogland commented Oct 11, 2022

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Oct 11, 2022

Uh oh!

blueorangutan commented Oct 11, 2022

Uh oh!

blueorangutan commented Oct 12, 2022

Uh oh!

blueorangutan commented Oct 13, 2022

Uh oh!

blueorangutan commented Oct 13, 2022

Uh oh!

blueorangutan commented Oct 13, 2022

Uh oh!

DaanHoogland commented Oct 14, 2022

Uh oh!

blueorangutan commented Oct 14, 2022

Uh oh!

blueorangutan commented Oct 14, 2022

Uh oh!

blueorangutan commented Oct 14, 2022

Uh oh!

blueorangutan commented Oct 14, 2022

Uh oh!

DaanHoogland commented Oct 17, 2022

Uh oh!

blueorangutan commented Oct 17, 2022

Uh oh!

blueorangutan commented Oct 17, 2022

Uh oh!

weizhouapache commented Oct 17, 2022

Uh oh!

RodrigoDLopez commented Oct 24, 2022

Uh oh!

weizhouapache commented Oct 24, 2022

Uh oh!

DaanHoogland Dec 2, 2022

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented Dec 2, 2022

Uh oh!

blueorangutan commented Dec 2, 2022

Uh oh!

blueorangutan commented Dec 2, 2022

Uh oh!

blueorangutan commented Dec 2, 2022

Uh oh!

blueorangutan commented Dec 2, 2022

Uh oh!

blueorangutan commented Dec 2, 2022

Uh oh!

DaanHoogland commented Dec 6, 2022

Uh oh!

blueorangutan commented Dec 6, 2022

Uh oh!

codecov bot commented Sep 29, 2022 •

edited

Loading

DaanHoogland commented Dec 13, 2022 •

edited

Loading